ARROW-11038: [Rust] Removed unused trait and Result. #9017
Conversation
rust/arrow/src/array/builder.rs
Outdated
There was a problem hiding this comment.
This change was motivated by T not really requiring ArrowPrimitiveType, only ArrowNativeType, and is required for a major simplification on the Buillders, #9019
Codecov Report
@@ Coverage Diff @@
## master #9017 +/- ##
==========================================
- Coverage 82.87% 82.87% -0.01%
==========================================
Files 201 201
Lines 49739 49733 -6
==========================================
- Hits 41220 41215 -5
+ Misses 8519 8518 -1
Continue to review full report at Codecov.
|
Dandandan
left a comment
Dandandan
left a comment
There was a problem hiding this comment.
Nice, LGTM 👍 I believe there are also quite some other places returning unneeded Results.
| /// and resizes the buffer as needed. | ||
| /// | ||
| /// The values of the newly added elements are undefined. | ||
| /// The values of the newly added elements are 0. |
| pub type UInt64BufferBuilder = BufferBuilder<UInt64Type>; | ||
| pub type Float32BufferBuilder = BufferBuilder<Float32Type>; | ||
| pub type Float64BufferBuilder = BufferBuilder<Float64Type>; | ||
| pub type Int8BufferBuilder = BufferBuilder<i8>; |
There was a problem hiding this comment.
👍 This is a nice simplification
|
I also merged from master and ran the tests locally to make sure this didn't logically conflict. Everything was good to go! |
|
This is a nice cleanup -- thank you @jorgecarleitao |
5 participants
This PR removes an unused trait and associated API that returns
Result<()>for infalible implementationsBoth of these are historical artifacts derived from using
io::write, which was abandoned because these operations are infalible.